Some improvements in tests #2: (joomla#13398)

* Some improvements in tests #2:
- fix callable name mismatches
- removed closing tags (also one that's in other PR, to not clash)
- removed loop that does nothing

* Revert removal of empty loop, as $i is decremented in the while statement

tests/unit/core/case/case.php

@@ -371,7 +371,7 @@ public function setExpectedError($error = null)
 	 */
 	protected function restoreErrorHandlers()
 	{
-		$this->setErrorhandlers($this->_stashedErrorState);
+		$this->setErrorHandlers($this->_stashedErrorState);
 	}
 
 	/**

tests/unit/stubs/discover1/challenger.php

@@ -1 +1 @@
-<?php /* @codingStandardsIgnoreFile Empty file */ ?>
+<?php /* @codingStandardsIgnoreFile Empty file */

tests/unit/stubs/discover1/columbia.php

@@ -1 +1 @@
-<?php /* @codingStandardsIgnoreFile Empty file */ ?>
+<?php /* @codingStandardsIgnoreFile Empty file */

tests/unit/suites/libraries/joomla/controller/JControllerBaseTest.php

@@ -172,6 +172,6 @@ protected function tearDown()
 	{
 		$this->restoreFactoryState();
 		unset($this->_instance);
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/feed/JFeedEntryTest.php

@@ -352,6 +352,6 @@ protected function tearDown()
 	{
 		unset($this->_instance);
 
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/feed/JFeedParserTest.php

@@ -55,7 +55,7 @@ public function testParse()
 
 		// Set the XML for the internal reader and move the stream to the <root> element.
 		$xml = '<root xmlns="http://bar.foo" xmlns:namespace="http://foo.bar"><tag1>foobar</tag1><namespace:tag2 attr="value" /></root>';
-		$this->_reader->Xml($xml);
+		$this->_reader->XML($xml);
 
 		// Advance the reader to the first <tag1> element.
 		do
@@ -207,7 +207,7 @@ public function testFetchNamespace()
 	public function testMoveToNextElement()
 	{
 		// Set the XML for the internal reader and move the stream to the <root> element.
-		$this->_reader->Xml('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
+		$this->_reader->XML('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
 		$this->_reader->next('root');
 
 		// Ensure that the current node is "root".
@@ -243,7 +243,7 @@ public function testMoveToNextElement()
 	public function testMoveToNextElementByName()
 	{
 		// Set the XML for the internal reader and move the stream to the <root> element.
-		$this->_reader->Xml('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
+		$this->_reader->XML('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
 
 		// Move to the next <node> element, which should be <node test="first">.
 		TestReflection::invoke($this->_instance, 'moveToNextElement', 'node');
@@ -266,7 +266,7 @@ public function testMoveToNextElementByName()
 	public function testMoveToClosingElement()
 	{
 		// Set the XML for the internal reader and move the stream to the <root> element.
-		$this->_reader->Xml('<root><child>foobar</child></root>');
+		$this->_reader->XML('<root><child>foobar</child></root>');
 		$this->_reader->next('root');
 
 		// Ensure that the current node is "root".
@@ -288,7 +288,7 @@ public function testMoveToClosingElement()
 	public function testMoveToClosingElementWithInternalElements()
 	{
 		// Set the XML for the internal reader and move the stream to the first <node> element.
-		$this->_reader->Xml('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
+		$this->_reader->XML('<root><node test="first"><child>foobar</child></node><node test="second"></node></root>');
 
 		// Advance the reader to the first <node> element.
 		do
@@ -335,7 +335,7 @@ public function testMoveToClosingElementWithInternalElements()
 	public function testMoveToClosingElementWithSelfClosingTag()
 	{
 		// Set the XML for the internal reader and move the stream to the first <node> element.
-		$this->_reader->Xml('<root><node test="first" /><node test="second"></node></root>');
+		$this->_reader->XML('<root><node test="first" /><node test="second"></node></root>');
 
 		// Advance the reader to the first <node> element.
 		do
@@ -399,6 +399,6 @@ protected function tearDown()
 		unset($this->_instance);
 		unset($this->_reader);
 
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/feed/JFeedTest.php

@@ -450,6 +450,6 @@ protected function tearDown()
 	{
 		unset($this->_instance);
 
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/feed/parser/JFeedParserAtomTest.php

@@ -247,7 +247,7 @@ public function testHandleUpdated()
 	public function testInitialise($expected, $xml)
 	{
 		// Set the XML for the internal reader.
-		$this->_reader->Xml($xml);
+		$this->_reader->XML($xml);
 
 		// Advance the reader to the first element.
 		do
@@ -329,6 +329,6 @@ protected function tearDown()
 		unset($this->_instance);
 		unset($this->_reader);
 
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/feed/parser/JFeedParserRssTest.php

@@ -453,7 +453,7 @@ public function testHandleWebmaster()
 	public function testInitialise($expected, $xml)
 	{
 		// Set the XML for the internal reader.
-		$this->_reader->Xml($xml);
+		$this->_reader->XML($xml);
 
 		// Advance the reader to the first element.
 		do
@@ -576,6 +576,6 @@ protected function tearDown()
 		unset($this->_instance);
 		unset($this->_reader);
 
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/form/JFormTest.php

@@ -78,8 +78,8 @@ private function _showXml($form)
 		$dom = new DOMDocument('1.0');
 		$dom->preserveWhiteSpace = false;
 		$dom->formatOutput = true;
-		$dom->loadXml($form->getXml()->asXml());
-		echo $dom->saveXml();
+		$dom->loadXML($form->getXml()->asXml());
+		echo $dom->saveXML();
 	}
 
 	/**

tests/unit/suites/libraries/joomla/google/JGoogleDataAdsenseTest.php

@@ -261,7 +261,7 @@ public function testGenerateReport()
 		$timezone = new DateTimeZone('Europe/London');
 		$start = new DateTime('now');
 		$end = new DateTime;
-		$end->setTimestamp(time() + 3600)->setTimeZone($timezone);
+		$end->setTimestamp(time() + 3600)->setTimezone($timezone);
 
 		$result = $this->object->generateReport('accountID', time(), time() + 100000, array('option' => 'value'));
 		$this->assertEquals($result, array('rows' => array(1, 2), 'totalMatchedRows' => 1));

tests/unit/suites/libraries/joomla/google/JGoogleDataCalendarTest.php

@@ -287,7 +287,7 @@ public function testCreateEvent()
 		$timezone = new DateTimeZone('Europe/London');
 		$start = new DateTime('now');
 		$end = new DateTime;
-		$end->setTimestamp(time() + 3600)->setTimeZone($timezone);
+		$end->setTimestamp(time() + 3600)->setTimezone($timezone);
 
 		$result = $this->object->createEvent('calendarID', time(), time() + 100000, array('option' => 'value'));
 		$this->assertEquals($result, array('items' => array('1' => 1, '2' => 2)));

tests/unit/suites/libraries/joomla/model/JModelDatabaseTest.php

@@ -123,6 +123,6 @@ protected function tearDown()
 	{
 		$this->restoreFactoryState();
 		unset($this->_instance);
-		parent::teardown();
+		parent::tearDown();
 	}
 }

tests/unit/suites/libraries/joomla/table/JTableNestedTest.php

@@ -785,7 +785,7 @@ protected function getDataSet()
 	 */
 	protected function setUp()
 	{
-		parent::setup();
+		parent::setUp();
 
 // 		$this->saveFactoryState();