Fix process group behavior on Windows #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the process group behavior on Windows and makes sure descendant processes are properly reaped together with the main Rokit runner process job that spawned them. This unfortunately broke due presumably to some internal mechanisms in
command-group
and therefore its successor crateprocess-wrap
changing.command-group
works as expected (this is what Foreman and Aftman use)command-group
did not initially work as expected - but now works the same as v1 after migrating to the.group()
builder APIprocess-wrap
have worked out so far. Their examples of migrating from different versions of thecommand-group
crate do not preserve the same behavior that the older crate had.