Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script improvements #48

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

filiptibell
Copy link
Collaborator

Some minor improvements to the install.sh script:

  • Add setting to fail the entire script if any command fails instead of silently continuing
  • Add setting to do the same for piped commands
  • Fix unnecessarily escaped quotes (\") in awk regex
  • Fix last newline being printed out as literal "\n" when a shell does not support escapes in echo

@filiptibell filiptibell merged commit 8bae269 into main Jul 16, 2024
10 checks passed
@filiptibell filiptibell deleted the install-script-improvements branch July 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant