Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve arch detection algorithm, add more tests #26

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

filiptibell
Copy link
Collaborator

This PR improves the string matching algorithm for process architectures such as x86, x64, arm64, arm32 in artifact names, and adds more tests, including real-world tool artifacts.

Notably, it fixes tarmac being detected as arm architecture and failing to install.

@filiptibell filiptibell merged commit 9abc4bb into main Jun 13, 2024
10 checks passed
@filiptibell filiptibell deleted the improve-artifact-compatibility branch June 13, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants