[bugfix](use after free) should not set finish depdency any more if t…

…ask ctx lock failed (apache#32730) Co-authored-by: yiguolei <[email protected]>
rohitrs1983 · Mar 24, 2024 · e8fc456 · e8fc456
1 parent b9c1d05
commit e8fc456
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/be/src/vec/sink/writer/async_result_writer.cpp b/be/src/vec/sink/writer/async_result_writer.cpp
@@ -101,7 +101,6 @@ Status AsyncResultWriter::start_writer(RuntimeState* state, RuntimeProfile* prof
         RETURN_IF_ERROR(pool_ptr->submit_func([this, state, profile, task_ctx]() {
             auto task_lock = task_ctx.lock();
             if (task_lock == nullptr) {
-                _set_ready_to_finish();
                 return;
             }
             this->process_block(state, profile);
@@ -111,7 +110,6 @@ Status AsyncResultWriter::start_writer(RuntimeState* state, RuntimeProfile* prof
                 [this, state, profile, task_ctx]() {
                     auto task_lock = task_ctx.lock();
                     if (task_lock == nullptr) {
-                        _set_ready_to_finish();
                         return;
                     }
                     this->process_block(state, profile);