-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizable editor #39
base: master
Are you sure you want to change the base?
Resizable editor #39
Conversation
webview/shared/Editor/index.tsx
Outdated
theme: "vs-dark", | ||
automaticLayout: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shifting to the GraphQL Tab (under Body) causes the editor to keep expanding horizontally. Have a hunch that this is being caused by automaticLayout
. Could you fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automaticLayout is set to true in order to make the editor expand when resizing, if set to false, when resizing it wouldn't take the new layout, the property does allow for this behaviour to happen, but I need it for resizing and I am looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohinivsenthil A simple solution is to pass automaticLayout as a prop instead of statically setting it, so I think that's a good solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohinivsenthil could you checkout this PR?
No description provided.