Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add libxt6 #748

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: add libxt6 #748

merged 1 commit into from
Jan 18, 2024

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Jan 18, 2024

This adds libxt6 and fixes #731 (and rocker-org/devcontainer-templates#28).
According to my tests, it adds roughly 0.67 MB to the r-ver image.

@cboettig
Copy link
Member

yeah, I agree the warning messages are annoying here. Though I think ideally upstream packages could address this by handle a soft dependency better, I'm 👍 on merging this.

@eddelbuettel
Copy link
Member

eddelbuettel commented Jan 18, 2024

But @cboettig consider that this is 100% not what R does. It is either built with x11, or without. Building with, and then withdrawing run-time dependencies, was always a little wild in my eyes. It's all complicated because these have no x11 display but it is also known that certain font calculations etc require x11 mechanics. (I forget what percentage of packages need that but it is also why the xvfb-run wrapper trick for 'virtual' x11 in a virtual framebuffer when needed.)

So yes, not my stack, but I also think that should be put back. It is a really ugly UI wart otherwise.

@cboettig
Copy link
Member

@eddelbuettel thanks, excellent point, sounds like you're in favor too so I'll merge.

@cboettig cboettig merged commit 7d08837 into rocker-org:master Jan 18, 2024
8 checks passed
@dpprdan dpprdan deleted the fix/libxt6 branch January 18, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grDevices::grSoftVersion() warning: libxt6 missing
3 participants