-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tlmgr packages needed for quarto to knit to PDF #741
Conversation
Follow-up to rocker-org#721, adding tlmgr packages that *quarto* seems to need to knit to PDF. Without these, it takes a minute or more (depending on network) for first knit to happen apparently. Reported to me by users from University of Toronto
Thanks @yuvipanda , this looks good to me. |
Given that some users don't need these packages and it's not clear what packages Quarto requires, I doubt whether it's worth adding them. I think it depends on the purpose of this script. |
The difficulty with latex 'on demand' issues is that they depend on the document in question. The only real answer, if someone really needs latex, maybe adding texlive. Else '1 min' once per run is not so bad, really. |
For me, the goal is to make sure that the simplest possible document will knit to PDF. I think of those as 'these are the requirements for quarto' - similar to software package requirements, just in a different ecosystem. The packages added in this PR were required for the hello world of quarto document to knit: Simple document that was tried to knit--- title: "Untitled" format: pdf editor: visual --- So while additional tex packages that may be needed due to using extra features can be installed on demand, I think it's helpful to install the packages included in this PR as a baseline for 'support quarto'. |
The sample document I showed is a slight modification of what RStudio opens if you go to |
Given that we already include some tlmgr packages, I think it makes sense that the 'out-of-the-box' dependencies on tlmgr for features already included in this docker image (i.e. rocker/verse) include all those which would be needed for default behaviors:
I agree with @eitsupi that some users don't needs these packages. but that is also why we add latex late in the 'stack' (at So anyway, I appreciate all the points in general here but I'm in favor of merging this particular set. |
Then let's merge this. The increase in capacity seems to be about 20MB. |
Thank you, @cboettig @eddelbuettel and @eitsupi for your thoughtful stewardship of this project :) |
Follow-up to #721, adding tlmgr packages that quarto seems to need to knit to PDF. Without these, it takes a minute or more (depending on network) for first knit to happen apparently.
Reported to me by users from University of Toronto