Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gui and swift examples #6917

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Remove gui and swift examples #6917

merged 1 commit into from
Jul 21, 2024

Conversation

lukewilliamboswell
Copy link
Collaborator

This PR removes the gui and swift examples.

The gui platform is broken. I moved it to roc-lang/examples/pull/190, and restored it to a working condition; including a build script for the platform.

I would also like to move the Swift example. We have a PR that updates it but that has not been looked at in some time. It also needs to be moved to examples.

Removing these examples simplifies the work required to land a few other PR's that are in progress.

@lukewilliamboswell
Copy link
Collaborator Author

Note -- I've also updated the examples to basic-cli 0.13.0 so that CI will run.

We should wait for @Anton-4 before merging, as that is still a pre-release.

Copy link
Contributor

@bhansconnect bhansconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@lukewilliamboswell lukewilliamboswell merged commit 9814b24 into main Jul 21, 2024
17 checks passed
@lukewilliamboswell lukewilliamboswell deleted the remove-examples branch July 21, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants