sink findings bug (#536)

robusta-dev · Sep 12, 2022 · c88adb0 · c88adb0
1 parent 5c6a225
commit c88adb0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/robusta/core/playbooks/playbooks_event_handler_impl.py b/src/robusta/core/playbooks/playbooks_event_handler_impl.py
@@ -41,6 +41,9 @@ def handle_trigger(self, trigger_event: TriggerEvent) -> Optional[Dict[str, Any]
                     execution_event = fired_trigger.build_execution_event(
                         trigger_event, sink_findings
                     )
+                    # sink_findings needs to be shared between playbooks.
+                    # build_execution_event returns a different instance because it's running in a child process
+                    execution_event.sink_findings = sink_findings
                 except Exception:
                     logging.error(f"Failed to build execution event for {trigger_event.get_event_description()}")
 

diff --git a/src/robusta/utils/auth_provider.py b/src/robusta/utils/auth_provider.py
@@ -31,7 +31,7 @@ def _load_private_key(file_name: str) -> Optional[RSAPrivateKey]:
                 logging.info(f"Loaded private key file {file_name}")
                 return private_key
         except Exception:
-            logging.error(f"Could not load private key file {file_name}")
+            logging.error(f"Could not load private key file {file_name}", exc_info=True)
 
         return None
 
@@ -43,6 +43,6 @@ def _load_public_key(file_name: str) -> Optional[RSAPublicKey]:
                 logging.info(f"Loaded public key file {file_name}")
                 return public_key
         except Exception:
-            logging.error(f"Could not load public key file {file_name}")
+            logging.error(f"Could not load public key file {file_name}", exc_info=True)
 
         return None