Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new simple cpu limit strategy #374

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

RoiGlinik
Copy link
Contributor

@RoiGlinik RoiGlinik commented Dec 10, 2024

New KRR strategy.

the default simple strategy suggests to set cpu limits to none always.

Some users use multi-tenants clusters and would like a strategy where cpu limit can be set to specific cpu percentile.

New simple_limit strategy will support this use case. supports cpu request and limit percentiles and use them for the cpu recommendations.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@nherment nherment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me although I'm not very familiar with this part of the codebase.
Should there be some tests in addition? Although this change look simple, there are a few pieces of logic than can be tested.

@RoiGlinik RoiGlinik merged commit 5a0c464 into main Dec 10, 2024
2 checks passed
@RoiGlinik RoiGlinik deleted the new-strategy-with-cpu-limit branch December 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants