Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #177

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Update readme #177

merged 5 commits into from
Dec 13, 2023

Conversation

aantn
Copy link
Contributor

@aantn aantn commented Dec 10, 2023

@pavangudiwada can you make sure I didn't break any internal links:

  1. In the README itself
  2. In the code (@LeaveMyYard do we ever print CLI messages that link to the README?)

@aantn aantn requested a review from pavangudiwada December 10, 2023 19:58
pavangudiwada
pavangudiwada approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@pavangudiwada pavangudiwada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aantn aantn merged commit acb4aa4 into main Dec 13, 2023
2 checks passed
@aantn aantn deleted the update-readme branch December 13, 2023 08:41
@aantn
Copy link
Contributor Author

aantn commented Dec 13, 2023

@pavangudiwada can you search the code for any links to github/the readme and make sure we didn't break them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavangudiwada pavangudiwada pavangudiwada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aantn @pavangudiwada