Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mixins for prometheus metrics #141

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Refactor mixins for prometheus metrics #141

merged 4 commits into from
Sep 5, 2023

Conversation

LeaveMyYard
Copy link
Contributor

Rework usage of mixin pattern to make code more readable

@LeaveMyYard LeaveMyYard self-assigned this Sep 4, 2023
Avi-Robusta
Avi-Robusta approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Avi-Robusta Avi-Robusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
Just the one question about batches.
Did you check the output to verify its the same?

@LeaveMyYard
Copy link
Contributor Author

LeaveMyYard commented Sep 5, 2023 •
edited
Loading

Did you check the output to verify its the same?

Results are exactly the same as before changes

@LeaveMyYard LeaveMyYard merged commit 27817c4 into main Sep 5, 2023
1 check passed
@LeaveMyYard LeaveMyYard deleted the prometheus-metrics-mixin-refactoring branch September 5, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-Robusta Avi-Robusta Avi-Robusta approved these changes

Assignees

@LeaveMyYard LeaveMyYard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaveMyYard @Avi-Robusta