Push directive #254
Merged
Push directive #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reynir
commented
May 23, 2024
| Fmt.str "%a" (Config.pp_b ~sep) | ||
| (Config.Conf_map.B (Protocol_flags, flags))) | ||
| |> Option.to_list) | ||
| @ Option.value ~default:[] (Config.find Push config) | ||
| in | ||
| let reply = String.concat "," reply_things in |
There was a problem hiding this comment.
We may consider creating a Config.Conf_map.t instead...
We send the push options specified with --push configuration directive. How we serialized --protocol-flags in push reply was wrong in an insignificant way.
hannesm
reviewed
May 29, 2024
hannesm
reviewed
May 29, 2024
hannesm
reviewed
May 29, 2024
hannesm
reviewed
May 29, 2024
The comment about a_single_param (incorrectly referred to as a_param)
was unclear.
Also use the {|other string|} literal to avoid long, unreadable escape
sequences.
Co-authored-by: Hannes Mehnert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
--pushconfiguration directive.I think maybe our
a_paramis not correct, and I will take a look at that.