Fix console warning including 'undefined' and a type violation #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following console warning including 'undefined', if the user never specifies that config option
There's another instance of the same warning which null-coalesces the default of 20 before printing, which is more sensible.
It also fixes this typecast being wrong.
optionsRef.current.reconnectAttempts
is possibly undefined, andonReconnectStop
is not declared to accept that (hence the cast, I guess).After I'd changed that, my IDE warned me that reconnect section was an exact duplicate. I don't always pay attention to that warning, but since there were 2 functions doing the same thing, one with bugs and one without, it seemed a good candidate to extract to new a function so that they don't diverge again.
This change is split into 2 commits: the functional change to fix the bugs, then the refactor.
@robtaussig Please review!