Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on carriers for yarpserver --ros #1679

Merged
merged 2 commits into from
May 10, 2018

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented May 9, 2018

It fixes #722 .

This PR makes xmlrpc rossrv tcpros carriers mandatory for running yarpserver --ros.

Please review code.

Copy link
Collaborator

@barbalberto barbalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drdanz drdanz merged commit ec2d62c into robotology:master May 10, 2018
@drdanz
Copy link
Member

drdanz commented May 10, 2018

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarpserver used with --ros should not start if required carriers are not found/compiled
3 participants