Fix server expectText stuck #1563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
suggested changes
Feb 24, 2018
| ConstString result = in->readLine(terminatingChar, &lsuccess); | ||
| in->setReadTimeout(0.0); |
There was a problem hiding this comment.
We should probably get current timeout and reset the previous value
There was a problem hiding this comment.
Right, I didn't think about that, but now I checked and there is no easy way to get that: no getReadTimeout() or haveReadTimeout() method in the InputStream. Do you think is this the case to add one?
Nicogene
added
Component: Library - YARP_os
Type: Cleanup
|
Cherry-picked the first commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1542 this could be a less invasive fix than placing a default timeout on the stream.
Unless we want to go for #1542 (comment), let me know.
On the fly I also moved [StreamConnectionReader] implementation from h to cpp.