Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ergoCub FT to have one NWS for each part #505

Merged
merged 1 commit into from
May 16, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented May 10, 2023

Fix part of #485 by using the convention discussed in icub-tech-iit/documentation#271 . For consistency and for having a remapper for each part with FTs, I could also have introduced right_arm-FT_remapper.xml and left_arm-FT_remapper.xml files, but I avoided to do that for keeping the PR as simple as possible.

One thing that I had to modify, otherwise the new devices could have problem, were the attach and detach level, for which I followed #377 as it seems the only documented convention available.

I am not sure if I modified all the root .xml files that included the strain configuration files, but I am not sure if we can delete the one that are not necessary? In this way mantainance of these files is easier.

@traversaro
Copy link
Member Author

fyi @GiulioRomualdi @mebbaid @lrapetti @S-Dafarra

@traversaro traversaro marked this pull request as draft May 10, 2023 13:21
@traversaro
Copy link
Member Author

I converted this to draft as we still need to test on the robot.

@pattacini
Copy link
Member

CI failed with these logs:

@traversaro
Copy link
Member Author

CI failed with these logs:

* [dry-run_log_ergoCubSN000_xml.txt](https://github.com/robotology/robots-configuration/files/11442385/dry-run_log_ergoCubSN000_xml.txt)

* [dry-run_log_ergoCubSN000_dev.txt](https://github.com/robotology/robots-configuration/files/11442387/dry-run_log_ergoCubSN000_dev.txt)

Hopefully fixed by 22a8345 . It is great to have this CI!

@pattacini
Copy link
Member

pattacini commented May 11, 2023

Something to look into:

[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name l_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] Device left_leg-FT_remapper cannot execute attach
[ERROR] Cannot run attach action on device left_leg-FT_remapper
[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name r_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] Device right_leg-FT_remapper cannot execute attach
[ERROR] Cannot run attach action on device right_leg-FT_remapper
[ERROR] embObjMultipleFTsensors: BOARD left_leg-eb8-j0_3 (IP 10.0.1.8)   getTemperatureSensorMeasure() fails data for index: 0  not found
[ERROR] ParametricCalibratorEth:  Torso_Calibrator : number of joints of device to calibrate ( 2 ) does not match the number of joints in calibrator config file ( 3 )
[ERROR] Right_Arm_Calibrator cannot perform 'check hardware fault' operation because joint number 9 is out of range [].
[ERROR] Left_Arm_Calibrator cannot perform 'check hardware fault' operation because joint number 9 is out of range [].

The log: dry-run_log_ergoCubSN000_dev.txt.

@traversaro
Copy link
Member Author

That:

[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:

is suspect, basically it seems that is not seeing any sensor, see https://github.com/robotology/yarp/blob/de3581c48059e9b6df4ed82e03b577938065d9e8/src/devices/multipleanalogsensorsremapper/MultipleAnalogSensorsRemapper.cpp#L203 .

@traversaro
Copy link
Member Author

traversaro commented May 11, 2023

This PR and the CI revealed three bugs that will be fixed by the following PRs:

@pattacini
Copy link
Member

Re-running the CI.

@pattacini
Copy link
Member

pattacini commented May 16, 2023

@traversaro, the CI now is successful.
Feel free to put the PR in ready for review if it's working on the robot.

@traversaro traversaro marked this pull request as ready for review May 16, 2023 16:07
@traversaro
Copy link
Member Author

traversaro commented May 16, 2023

Feel free to put the PR in ready for review if it's working on the robot.

Just tested on the real robot, it is working fine, @GiulioRomualdi also tested it with the logger. @pattacini

@isorrentino
Copy link
Contributor

Hi @traversaro, would it make sense to do the same for the imus?

@traversaro
Copy link
Member Author

Hi @traversaro, would it make sense to do the same for the imus?

I personally agree and that would help with icub-tech-iit/documentation#271, but probably it is better to organize with @Nicogene on this. I would organize a quick meeting on this with the interested persons.

@traversaro traversaro deleted the ergocubft branch May 17, 2023 11:10
mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this pull request Jun 19, 2023
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants