-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add casadi-matlab-bindings if ROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS is ON and ROBOTOLOGY_USES_MATLAB is ON #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
Giulero,
nunoguedelha,
CarlottaSartore,
gabrielenava and
GiulioRomualdi
May 19, 2021 23:22
GiulioRomualdi
approved these changes
May 20, 2021
Giulero
approved these changes
May 20, 2021
Today I tested, and (at least on Windows with conda's CasADi) this does work as expected: >> import casadi.*
>> x = MX.sym('x')
x =
x
>> y = SX.sym('y',5)
Z = SX.sym('Z',4,2)
y =
[y_0, y_1, y_2, y_3, y_4]
Z =
[[Z_0, Z_4],
[Z_1, Z_5],
[Z_2, Z_6],
[Z_3, Z_7]] Instruction for setup:
env details:
|
Given @Giulero and @GiulioRomualdi approval and my tests, I think we can merge. |
This was referenced May 21, 2021
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
… ON and ROBOTOLOGY_USES_MATLAB is ON (robotology#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the build of https://github.com/dic-iit/casadi-matlab-bindings to build the CasADi MATLAB bindings if both ROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS and ROBOTOLOGY_USES_MATLAB are ON. The concept of the repo https://github.com/dic-iit/casadi-matlab-bindings is similar to https://github.com/robotology/yarp-matlab-bindings : a repo to commit the SWIG-generated MATLAB bindings files, to avoid to require the user to install the SWIG fork required to generate it.
This will permit to all users to use CasADi linked with all other dependencies compiled as part of the superbuild, as opposed to ABI problems that can arise when the CasADi binary is used, Furthermore, it would permit to install CasADi MATLAB bindings in conda via:
Fix #719 .