Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROBOTOLOGY_USES_ROS2 and ROBOTOLOGY_USES_MOVEIT options #1746

Merged
merged 20 commits into from
Dec 3, 2024
Merged

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Nov 26, 2024

Fix #1348 .

This is still preliminary work, and it only works if -DROBOTOLOGY_PROJECT_TAGS is set to Unstable until we fix #1740 . However as it is working fine locally, I thought it was worth opening the PR to collect preliminary feedback.

For now I still need to add CI for these two options, but to test that the options are working I run:

pixi run build-ros2

I did not check if anything is working, but at least I could check that the ROS packages are correctly installed via pixi run build-ros2 && pixi run -e ros2 ros2 pkg list.

Note that the documentation is provided to enable the options with all supported way of installing dependencies (apt, conda, pixi), I just tested the option with pixi as it is faster.

This PR is also requireds icub-tech-iit/xcub-moveit2#27 to be merged and released.

@traversaro
Copy link
Member Author

@martinaxgloria @Nicogene how would you like the (future, it will not be fast) conda package to be named? xcub-moveit or xcub-moveit2?

@martinaxgloria
Copy link
Contributor

@martinaxgloria @Nicogene how would you like the (future, it will not be fast) conda package to be named? xcub-moveit or xcub-moveit2?

I'd like xcub_moveit2 as the name of the repository. I think that xcub_moveit could be misleading since someone could think that it is a MoveIt 1 project. But I'm also open to name the conda package without the moveit version specified

@traversaro
Copy link
Member Author

This PR is missing just a tag for xcub-moveit2 and then we are ready to go. @martinaxgloria can you review the session on the required dependencies for apt in https://github.com/robotology/robotology-superbuild/pull/1746/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R151 . For the conda-forge ones I tested it in CI, but for apt I do not plan to add CI for now (too much effort in mantainance).

@martinaxgloria
Copy link
Contributor

Hi @traversaro, everything seems ok to me, thanks

@traversaro
Copy link
Member Author

The Windows ROS2 CI fails due to the length of the build path. There are several possible workarounds, but to unblock the build let's skip the CI for now.

@traversaro traversaro merged commit 695e4d5 into master Dec 3, 2024
26 of 29 checks passed
@traversaro traversaro deleted the fix1348 branch December 3, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update YARP in ROBOTOLOGY_PROJECT_TAGS=Stable to yarp-3.10 Add ROBOTOLOGY_USES_ROS2 option
2 participants