[model_io] Fix implicit dependency of URDF parsers on system locale #289
Conversation
| } | ||
|
|
||
| bool inline stringToInt(const std::string & inStr, int & outInt) | ||
| bool inline stringToIntWithClassicLocale(const std::string & inStr, int & outInt) |
There was a problem hiding this comment.
Just a curiosity, why not using a templated function now that inside there are no differences between the toDouble and toInt and toUnsigned functions?
There was a problem hiding this comment.
Good point, I think we can do it once we fixed the bug.
| } | ||
|
|
||
| bool inline stringToInt(const std::string & inStr, int & outInt) | ||
| bool inline stringToIntWithClassicLocale(const std::string & inStr, int & outInt) |
There was a problem hiding this comment.
Is there any reason for the code duplication?
There was a problem hiding this comment.
Yes, for historical reason the urdf_model/boost_replacements.h headers is only included in Windows, and these are private functions of the library. We can think of moving this functions to a public header, but I would prefer to to that in a separate pull request, as any additional public function then needs to be maintained, documented and modified with care to avoid breaking downstream code.
See #288