Feature/fw updater bat #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSECode
force-pushed
the
feature/fwUpdaterBat
branch
from
24ea007 to
e4cce55
Compare
4 tasks
MSECode
force-pushed
the
feature/fwUpdaterBat
branch
from
41faab0 to
141e34c
Compare
3 tasks
valegagge
requested changes
Jan 8, 2024
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/embot_app_eth_theBATservice.cpp
Outdated
Show resolved
Hide resolved
Keep if clause commented since not working properly Even if canmonitor params are not passed by icub-main the memory remains dirty and a value different from zero is passed to the EMS. So we need to force the default config value and check better the CAN monitor behaviour
MSECode
force-pushed
the
feature/fwUpdaterBat
branch
from
32ed955 to
3004c10
Compare
|
This PR is linked to: |
valegagge
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Well done! 🚀
The EMS works properly only if the pr robotology/robots-configuration#603 has been merged, because the battery needs the CAN address 2 as it is explained in the note Just a more note about the need to set the address 2 to the bat board in this comment
MSECode
added a commit
to MSECode/icub-firmware
that referenced
this pull request
Jan 16, 2024
MSECode
added a commit
to MSECode/icub-firmware
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced with this PR are fully detailed at this link:
#445
and it goes to solve this issue:
robotology/icub-tech-support#1673