Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt with icub_firmware_shared version to 1.38.2 #95

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update CMakeLists.txt with icub_firmware_shared version to 1.38.2 #95

merged 1 commit into from
Mar 26, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 21, 2024 •
edited
Loading

Changes of this PR:

  • Reset status variable in struct eOas_battery_timedvalue_t datatype to uint16_t
  • Correct the enum values and max dimension enum definitions of eOas_battery_alarm_status_t
  • Update version to 1.38.2

Related to:

@MSECode MSECode requested review from pattacini and valegagge March 21, 2024 14:30
@MSECode MSECode self-assigned this Mar 21, 2024
This was referenced Mar 21, 2024
Merged
Merged
Merged
@marcoaccame marcoaccame self-requested a review March 21, 2024 15:36
valegagge
valegagge approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSECode
Update CMakeLists.txt with icub_firmware_shared version to 1.38.2
5494649 
Reset status to uint16_t
Correct the enum values of eOas_battery_alarm_status_t
Update protocol AS to 1.11
@MSECode MSECode force-pushed the feature/batUpdate branch from 76505e1 to 5494649 Compare March 26, 2024 14:53
marcoaccame
marcoaccame approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

eth/embobj/plus/comm-v2/icub/EoAnalogSensors.h Show resolved Hide resolved
@marcoaccame marcoaccame merged commit 768dce4 into robotology:devel Mar 26, 2024
1 of 2 checks passed
@MSECode MSECode deleted the feature/batUpdate branch December 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge valegagge approved these changes

@pattacini pattacini Awaiting requested review from pattacini

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @marcoaccame