Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amcfoc added support #103

Merged
merged 2 commits into from
Dec 11, 2024
Merged

amcfoc added support #103

merged 2 commits into from
Dec 11, 2024

Conversation

SanLordKevin
Copy link

@SanLordKevin SanLordKevin commented Dec 9, 2024 •
edited
Loading

Added support for the amcfoc to be recognizable by the FirmwareUpdater.

@SanLordKevin SanLordKevin self-assigned this Dec 9, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SanLordKevin SanLordKevin changed the title amcfoc added support amcfoc added support Dec 10, 2024
marcoaccame
marcoaccame approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks,

The PR can be merged safely w/out updating the icub_firmware_shared version as for now we use this feature only for WIP on amcfoc.

Later on I will change the icub_firmware_shared version in here and the required one by icub-main. But not for now.

@marcoaccame marcoaccame changed the base branch from master to devel December 11, 2024 12:44
@marcoaccame marcoaccame merged commit 8d6d723 into robotology:devel Dec 11, 2024
2 checks passed
@SanLordKevin SanLordKevin deleted the amcfoc_addition branch December 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

Assignees

@SanLordKevin SanLordKevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanLordKevin @CLAassistant @marcoaccame