-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nws/nwc naming convention #367
Conversation
nws
/nwc
naming convention
Great @davidegorbani, I will go trough this PR soon. CI on Windows is failing, but the issue seems to be unrelated to your PR. Moreover, before merging I would like to fix #366 and do a Release, since this PR will break compatibility with old configurations. |
I rebased the branch on master, I tested on my laptop the HumanStateVisualizer and it is working fine. |
Great, however there seems to be a conflict in the files and the commit history seems not to be clean. We can have a look at this together tomorrow! |
a9fc4ed
to
559af64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @davidegorbani. A couple of comments:
- can you update the
CHANGELOG.md
with the relevant modifications? - I think we can also change the name of the folders in which those files are currently stored (so removing the
wrappers
andremappers
folder).
Yes, sure.
I was considering changing those names, is it fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidegorbani can you take care of updating all the configuration files inside conf
? Even if you cannot test them, you can simply fins and replace all the names. Eventually we can test together at least those that are actively used for the ergoCub robot teleoperation.
Yes, sure! |
I changed also the name of the namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidegorbani, we can proceed merging!
This PR closes #359; with this PR the naming convention of the Wrapper and the Remapper is updated to the
nws
/nwc
now used for the servers and clients in YARP.