Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to wait for data available in interface #357

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

lrapetti
Copy link
Member

With this PR I am adding a timeout to wait for data being available on the interface. This avoid problems such as #356.

Moreover, in 7ae0be3 I standardizing the capitalization for the LogPrefix variable.

@lrapetti lrapetti self-assigned this Sep 28, 2023
@lrapetti lrapetti requested a review from traversaro September 28, 2023 10:03
@lrapetti
Copy link
Member Author

@traversaro @GiulioRomualdi @davidegorbani I don't know if this solution make sense to you, or you can propose alternatives? (clearly we might add a parameter that defines the timeout to avoid the device getting stuck waiting)

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, it probably make sense to extend the IHumanState interface to also provide this information about the status, as conflating getNumberOfJoints == 0 ==> no first data received may be a bit problematic. Anyhow, as a first fix this is perfect.

@lrapetti
Copy link
Member Author

As a general comment, it probably make sense to extend the IHumanState interface to also provide this information about the status, as conflating getNumberOfJoints == 0 ==> no first data received may be a bit problematic. Anyhow, as a first fix this is perfect.

That make sense, I can open an issue related to this. As usual, a concern is that it would imply that we should update the associated thrift message, and old datasets might no longer be compatible (however, I don't think we are directly using IHumanState dumped signal so it should not be a problem).

@lrapetti
Copy link
Member Author

As a general comment, it probably make sense to extend the IHumanState interface to also provide this information about the status, as conflating getNumberOfJoints == 0 ==> no first data received may be a bit problematic. Anyhow, as a first fix this is perfect.

That make sense, I can open an issue related to this.

Done #360, I'll proceed updating the CHANGELOG.md and merging.

@lrapetti lrapetti force-pushed the add-timeout-interface branch from cc004c3 to cf36f51 Compare September 28, 2023 11:03
@lrapetti lrapetti merged commit 20451d7 into master Sep 28, 2023
6 checks passed
@lrapetti lrapetti deleted the add-timeout-interface branch September 28, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants