Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpOASES updated to version 3.2.0 #5

Merged
merged 2 commits into from
Jan 26, 2018
Merged

qpOASES updated to version 3.2.0 #5

merged 2 commits into from
Jan 26, 2018

Conversation

gabrielenava
Copy link
Collaborator

@gabrielenava gabrielenava commented Dec 27, 2017

I updated qpOASES to version 3.2.0 with the hope of solving this issue. I did two different commits:

I would like to proper test the new qpOASES before merging.

@gabrielenava
Copy link
Collaborator Author

I tested the update in simulation. Nothing changed from the controllers point of view. Still, tests on the robot are missing.

@traversaro
Copy link
Contributor

We typically use [WIP] for avoiding accidental merges.

@gabrielenava gabrielenava changed the title [NO MERGE] qpOASES updated to version 3.2.0 [WIP] qpOASES updated to version 3.2.0 Jan 15, 2018
@gabrielenava
Copy link
Collaborator Author

Tested on iCubGenova02. No issues to report. The behaviour of the robot was (qualitative) as before the update. I think we can merge this PR. Only question: is qpOASES used only for the balancing controllers?

@gabrielenava gabrielenava changed the title [WIP] qpOASES updated to version 3.2.0 qpOASES updated to version 3.2.0 Jan 24, 2018
@traversaro
Copy link
Contributor

+1 to merging this PR.

Only question: is qpOASES used only for the balancing controllers?

https://github.com/search?l=Matlab&q=org%3Arobotology+qpOASES&type=Code
https://github.com/search?l=Matlab&q=org%3Arobotology-playground+qpOASES&type=Code

As OpenSOT uses another fork, I guess the answer is yes.

@gabrielenava
Copy link
Collaborator Author

Ok, merging then!

@gabrielenava gabrielenava merged commit ae96455 into robotology-dependencies:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants