-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major CAN rework #229
Major CAN rework #229
Conversation
c202af1
to
b848b89
Compare
3baa657
to
c59bd95
Compare
This allows the statusword listener to notify the internal control mode observer.
The SDO segmented test is prone to fail on Travis due to intermediate messages being skipped.
This PR has long exceeded the limit of 250 browseable commits, and helpful comments are buried deep among commit titles (#229 (comment)), so I'm going to close it, at last. Also, my initial assigment was due by the end of 2019 (kinda), and I need other people to test this code extensively. Both facts convinced me to merge apocanlypse now and start a new branch with moar follow-ups at some point afterwards (and another catchy name, too). Bonus TEO feature if you can find the easter egg. This PR was developed along with new .ini files on robot-specific repositories: roboticslab-uc3m/teo-configuration-files@b17cea8, roboticslab-uc3m/asibot-configuration-files@e02bfc6. Disclaimers:
Happy 2020. PS "apocanlypse now" was totally unintended. PS2 just noticed (Feb '20) the alternative spelling "Majorcan rework" (as in the Majorca island). Sorry, it's stronger than me. |
This PR tracks several [CAN-TEO] issues, detailed as follows:
pulsesPerSample
Technosoft device configuration parameter.CanBusControlboard::open
needed some love; now, most stuff was moved to the respective subdevice initialization methods or other, more convenient places.yarp::dev::IMotor
,yarp::dev::IMotorEncoders
andyarp::dev::IAxisInfo
in TechnosoftIpos.TODOs:
std::atomic
in newStateVariables
class.std::bind
?).DriveStatusMachine
methods instead ofCanOpen::rpdo1
?StateVariables::reportBitToggle
(YARP logger?)checkMotionDone
failures).