Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue that the input box will be magnified when clicking on it in mobile browser #204

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

dearDreamWeb
Copy link
Contributor

@robinmoisson
Copy link
Owner

Thanks @dearDreamWeb!

I'm on android so I don't see that behavior, which looks a little annoying. I don't want to prevent the user from pinch-zooming if we can help it though, and I think your current solution would prevent it.

It looks like (in the SO question as well) that setting the font-size to 16px in the input prevents this behavior. It's currently at 14px and I think it's an acceptable compromise, even if a little arbitrary from Safari.

It would preserve the ability for the user to zoom. I don't have Safari, could you try and check if that works?

@dearDreamWeb
Copy link
Contributor Author

I tried it, it's ok

@dearDreamWeb
Copy link
Contributor Author

I forgot to delete the configuration added by viewport, I need to try again

@dearDreamWeb
Copy link
Contributor Author

It's ok

@AndrewHaglund
Copy link

Thanks for fixing this @dearDreamWeb! I noticed this issue yesterday and was planning on filing a bug. Would it be possible to get this merged in @robinmoisson or does it need additional testing that I could help with?

@robinmoisson
Copy link
Owner

Just tested it and that looks great to me! Thanks for the good work @dearDreamWeb and thanks for the ping @AndrewHaglund, I'm merging and deploying a patch bump.

@robinmoisson robinmoisson merged commit bc7a241 into robinmoisson:main Jan 5, 2025
@robinmoisson
Copy link
Owner

Done, 3.5.1 is now live on npm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants