Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates #6

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Small updates #6

merged 5 commits into from
Jun 21, 2021

Conversation

back-2-95
Copy link
Contributor

@back-2-95 back-2-95 commented Jun 21, 2021

  • Added .gitignore for development
  • Fix License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead
  • LICENSE file from https://choosealicense.com/licenses/gpl-2.0/
  • Changed machbarmacher/gdpr-dump to be loaded via type=package repository
  • composer validate passes now

@back-2-95 back-2-95 marked this pull request as ready for review June 21, 2021 12:36
@back-2-95 back-2-95 mentioned this pull request Jun 21, 2021
@robiningelbrecht
Copy link
Owner

@back-2-95 Feel free to add your self as an author to the composer.json file...?

@back-2-95
Copy link
Contributor Author

Ah yes, I can do that.

I'm facing a problem now with PHP versions.

machbarmacher/gdpr-dump requires bomoko/mysql-cnf-parser:0.0.2 which requires nette/finder:^3.0@dev which requires PHP 8. 😅

@robiningelbrecht
Copy link
Owner

Maybe we could check the possibility to use https://github.com/ifsnop/mysqldump-php? The repo we are using is forked from that one

@back-2-95
Copy link
Contributor Author

back-2-95 commented Jun 21, 2021

I created a fork https://packagist.org/packages/druidfi/gdpr-mysqldump from machbarmacher/gdpr-dump and changed the dependencies. I also included PRs:

Now I was able to install this with Drupal 8 site.

@robiningelbrecht robiningelbrecht merged commit 8c7783e into robiningelbrecht:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants