Use the system clock to determine elapsed time #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test makes a tick callback run for longer than the update interval by busy-waiting. The purpose of having it is that the stopwatch should not rely on being able to get an interval event for each and every interval. Instead, it should use the amount of elapsed time as measured by the system clock.
This test is to verify that the stopwatch's time does NOT increase while the stopwatch is in a "stopped" state. The codebase already passes the test as of this commit, but when it is switched to actually use the system clock to get the elapsed time, this becomes important to verify.
|
👍 Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Rob,
I created a patch to make it use the system clock, rather than relying on receiving every interval, to determine the elapsed time. This allows it to show the true elapsed time even if it missed (or duplicated) some of its timer events, which should make it more accurate.
The main reason I did this was for use on Android and iOS. On iOS, if I go back to the home screen or switch to a different browser tab, the page stops receiving javascript timer events. On Android it manages to send events while in the background, but only until the screen goes to sleep. With the code as it stands, the stopwatch won't advance when it's not receiving events, so you can't trust the time it shows if the page isn't constantly visible. With my patch, it is able to catch up and display the true elapsed time, even if the device has gone to sleep in the middle.
I would also guess that this probably fixes the problem @Blacksus described in #6. I don't know if it actually does fix it, because I never ran into the #6 problem myself. But this patch would make it show an accurate elapsed time, even if the time between the interval events becomes weird.