Skip non selectable items #456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b3ngg thanks for the PR. Got 15 failing tests with these changes though. |
|
@rob-balfre Whoops, sorry. Unfortunately the tests are not working for me locally. I try to get them working when I've got some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #404
This prevents the selection of non selectable item when searching a select field and using the arrow keys. This improves the user experience when searching for example in a group select without
isGroupHeaderSelectableenabled as the first item is directly selected and no additional arrow key usage is required.For this reason I added two new functions for manipulating the
hoverItemIndexthat incorporate a mechanism for skipping non selectable items. One for setting to a specific index and one for incrementing or decrementing the index.I used the the new methods in a few places, however, due to my lack of overview of the codebase, I am not sure if it fits in all places.
PS: Sorry I opened #455 by accident.