Bugfix/unmount memory leak #3708
Open
+38
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
g4rb4g3
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
|
I just double checked on Android and it seems like this is an iOS issue only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue that memory would not be freed up when the MapView was unmounted on iOS.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
without this memory consumption increases whenever a new MapView is mounted
with this fix memory is freed up when a MapView is unmounted
Component to reproduce the issue you're fixing
I've updated the ShowMap.tsx and added an (un)mount button there. Whenever you press this button and a MapView is mounted memory usage increases but never decreases when unmounting unless this fix is in place.