Avoid adding the STEAMWORKS_NET define symbol to non-standalone platorms #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # com.rlabrecque.steamworks.net/Editor/RedistInstall.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added some logic to avoid the
STEAMWORKS_NETscripting define symbol being automatically added to unsupported platforms like Android, iOS, etc.In these platforms, if
STEAMWORKS_NETis found in the defines, it will be removed since it will not work anyway.Explanation:
In my case, I do not like spreading
#if STEAMWORKS_NETover my code base. I do it only in some special cases.Scripts with a lot of Steam SDK library usage are part of an AssemblyDefinition like the one below:
