Add detailed logs if steam Init fails. #648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlabrecque
reviewed
Sep 19, 2024
| @@ -260,7 +261,10 @@ public static ESteamAPIInitResult InitEx(uint unIP, ushort usGamePort, ushort us | |||
| } | |||
| else { | |||
| initResult = ESteamAPIInitResult.k_ESteamAPIInitResult_FailedGeneric; | |||
| OutSteamErrMsg = "[Steamworks.NET] Failed to initialize CSteamAPIContext"; | |||
| if(!string.IsNullOrEmpty(OutSteamErrMsg)) | |||
| OutSteamErrMsg = $"[Steamworks.NET] Failed to initialize CSteamAPIContext: {OutSteamErrMsg}"; | |||
There was a problem hiding this comment.
Can this ever get hit? If OutSteamErrMsg is not empty, does that not also mean we'll never get into the branch at L256?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new InitEx method is awesome and provides much more data if something breaks. I've changed the method slightly to expose the underlying error that the Steam SDK produces instead of the generic Steamworks.NET error message.