Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable auto offset committing #90

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

rkrishn7
Copy link
Owner

@rkrishn7 rkrishn7 commented Mar 5, 2024

Description

Please include a clear and concise description of what the pull request does. Explain the problem it solves or the feature it adds to the project. If this PR fixes an open issue, please link to the issue here, using the format "Fixes #issue_number".

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

Before submitting your PR, please review and confirm the following:

  • I have performed a self-review of my own code and ensured it adheres to the project guidelines and coding standards.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation, if applicable.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • Integration tests have been added for relevant changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context about the pull request here. This can include challenges faced, decisions made, or any other relevant information that would help the reviewers understand your changes better.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.9%. Comparing base (bb1ef3e) to head (1dc5ca6).

Additional details and impacted files
Files Coverage Δ
src/kiwi/src/source/kafka.rs 3.7% <0.0%> (ø)

@rkrishn7 rkrishn7 merged commit 2ebcfab into main Mar 6, 2024
8 of 9 checks passed
@rkrishn7 rkrishn7 deleted the fix/kafka-enable-auto-commit branch March 6, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant