Revert "Element / Species - add n_electrons"

This reverts commit 97ea180.
rkingsbury · Jul 21, 2024 · d7e72bf · d7e72bf
1 parent 97ea180
commit d7e72bf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/src/pymatgen/core/periodic_table.py b/src/pymatgen/core/periodic_table.py
@@ -447,11 +447,6 @@ def parse_orbital(orb_str):
             data = list(Element(sym).full_electronic_structure) + data[1:]
         return data
 
-    @property
-    def n_electrons(self) -> int:
-        """Total number of electrons in the Element."""
-        return sum([t[-1] for t in self.full_electronic_structure])
-
     @property
     def valence(self) -> tuple[int | np.nan, int]:
         """Valence subshell angular moment (L) and number of valence e- (v_e),
@@ -1147,13 +1142,6 @@ def parse_orbital(orb_str):
             data = list(Element(sym).full_electronic_structure) + data[1:]
         return data
 
-    # NOTE - copied exactly from Element. Refactoring / inheritance may improve
-    # robustness
-    @property
-    def n_electrons(self) -> int:
-        """Total number of electrons in the Species."""
-        return sum([t[-1] for t in self.full_electronic_structure])
-
     # NOTE - copied exactly from Element. Refactoring / inheritance may improve
     # robustness
     @property

diff --git a/tests/core/test_periodic_table.py b/tests/core/test_periodic_table.py
@@ -169,11 +169,6 @@ def test_from_row_and_group(self):
         for k, v in cases.items():
             assert ElementBase.from_row_and_group(v[0], v[1]) == Element(k)
 
-    def test_n_electrons(self):
-        cases = {"O": 8, "Fe": 26, "Li": 3, "Be": 4}
-        for k, v in cases.items():
-            assert Element(k).n_electrons == v
-
     def test_valence(self):
         cases = {"O": (1, 4), "Fe": (2, 6), "Li": (0, 1), "Be": (0, 2)}
         for k, v in cases.items():
@@ -607,7 +602,6 @@ def test_sort(self):
 
     def test_species_electronic_structure(self):
         assert Species("Fe", 0).electronic_structure == "[Ar].3d6.4s2"
-        assert Species("Fe", 0).n_electrons == 26
         assert Species("Fe", 0).full_electronic_structure == [
             (1, "s", 2),
             (2, "s", 2),
@@ -620,7 +614,6 @@ def test_species_electronic_structure(self):
         assert Species("Fe", 0).valence == (2, 6)
 
         assert Species("Fe", 2).electronic_structure == "[Ar].3d6"
-        assert Species("Fe", 2).n_electrons == 24
         assert Species("Fe", 2).full_electronic_structure == [
             (1, "s", 2),
             (2, "s", 2),
@@ -632,7 +625,6 @@ def test_species_electronic_structure(self):
         assert Species("Fe", 2).valence == (2, 6)
 
         assert Species("Fe", 3).electronic_structure == "[Ar].3d5"
-        assert Species("Fe", 3).n_electrons == 23
         assert Species("Fe", 3).full_electronic_structure == [
             (1, "s", 2),
             (2, "s", 2),
@@ -644,7 +636,6 @@ def test_species_electronic_structure(self):
         assert Species("Fe", 3).valence == (2, 5)
 
         assert Species("Li", 1).electronic_structure == "1s2"
-        assert Species("Li", 1).n_electrons == 2
         # alkali metals, all p
         for el in ["Na", "K", "Rb", "Cs"]:
             assert Species(el, 1).electronic_structure.split(".")[-1][1::] == "p6", f"Failure for {el} +1"