do not allow an excessive number of parts #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is annoying! It bugs me that making a mere 100,000 parts should lead to excessive consumption of memory… but really, nobody does that for a good reason. This makes top-level (non-recursive) Email::MIME->new set a localized part counter to 0 and increment before it makes new subpart objects. If the counter exceeds the max, it will die early. It would be better to work, but this is better than eating all memory and crashing, right? Put together with help from Marc Bradshaw. Test forthcoming.
|
I'm by no means an expert on the codebase but I like what I see. I understand the frustration :) but this feels very pragmatic. Thanks |
rjbs
force-pushed
the
issue-66-too-many-parts
branch
from
c249130 to
3dcf096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is annoying! It bugs me that making a mere 100,000 parts should lead to excessive consumption of memory… but really, nobody does that for a good reason.
This makes top-level (non-recursive) Email::MIME->new set a localized part counter to 0 and increment before it makes new subpart objects. If the counter exceeds the max, it will die early.
It would be better to work, but this is better than eating all memory and crashing, right?
Put together with help from Marc Bradshaw.
Test forthcoming.
Fixes #66