Port debug commands to RzShell #4753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never used in the whole function. Hence, whatever it was supposed to do, it didn't
23 tasks
Originally it limited the addresses to trace. But it was not used in any test, and the implementation was not optimal. It allowed only specific addresses (no range). Also worked on strings (not ut64 values). Also, the usefulness is limited, considering the alternative to just not tracing a certain address.
XVilka
requested changes
Nov 30, 2024
| @@ -91,6 +91,7 @@ typedef enum { | |||
| RZ_OUTPUT_MODE_LONG_JSON = 1 << 6, | |||
| RZ_OUTPUT_MODE_TABLE = 1 << 7, | |||
| RZ_OUTPUT_MODE_QUIETEST = 1 << 8, | |||
| RZ_OUTPUT_MODE_GRAPH = 1 << 9, | |||
There was a problem hiding this comment.
Nice addition but there could be multiple types of graph - e.g. native, dot one, interactive, and so on. While it's less relevant in this PR, we should think this over nevertheless, possibly at some later stage. But preferably before the release.
There was a problem hiding this comment.
Yeah, would be nice. I can attempt to add it here. If it is too much struggle we can still do it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
dmivcommand, since it is an alias fordmidtacommand:Originally it limited the addresses to trace.
But it was not used in any test, and the implementation was not optimal.
It allowed only specific addresses (no range).
Also worked on strings (not ut64 values).
Also, the usefulness is limited, considering the alternative
to just not tracing a certain address.
Test plan
...
Closing issues
...