Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert zero-output EXPECT_ERR=<<EOF to single-line EXPECT_ERR= #4744

Merged

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Nov 26, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr converts zero-output EXPECT_ERR=<<EOF into single-line EXPECT_ERR= because:

  1. They take less lines and are faster to read.
  2. rz-test -i fixes zero-output stderr into single-line EXPECT_ERR=.

Conversion is done using:

(REGEX='EXPECT_ERR=<<EOF\nEOF' && grep -rPzl "$REGEX" test/db | xargs -n 1 perl -0777 -i -pe "s/$REGEX/EXPECT_ERR=/g")

Test plan

All builds are green.

Closing issues

...

@kazarmy kazarmy merged commit 56d9cf5 into rizinorg:dev Nov 26, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants