Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement iterator for hash tables and sets #4639

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Sep 18, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Adds iterators over (im)mutable values or immutable keys of hash tables and sets.

Supersedes #4500

Test plan

Added

Closing issues

...

XVilka

This comment was marked as resolved.

librz/util/ht/ht_inc.c Outdated Show resolved Hide resolved
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nitpicks

librz/util/ht/ht_inc.c Outdated Show resolved Hide resolved
librz/util/ht/ht_inc.c Outdated Show resolved Hide resolved
librz/util/ht/ht_inc.c Show resolved Hide resolved
librz/util/ht/ht_inc.c Outdated Show resolved Hide resolved
librz/util/ht/ht_inc.c Outdated Show resolved Hide resolved
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, those comments are not required.

@XVilka XVilka merged commit 3573148 into rizinorg:dev Sep 24, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants