-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linkerversion to rz-bin -I #4632
Conversation
I think I need to increase buffer size to cater with overflows in |
a705de3
to
f8a977f
Compare
@XVilka are both of the failing checks related to this issue or some other issue ? |
Ignore those, those are non-deterministic errors |
ignore the fuzz test failure. is unrelated. |
f8a977f
to
d112de1
Compare
please rebase on top of dev. |
d112de1
to
6d8d21c
Compare
cf27b7a
to
e03a3fb
Compare
e03a3fb
to
9375f96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the linker
field and use the compiler
one.
9375f96
to
f663d37
Compare
db496ec
to
d61afab
Compare
@wargio I am done with the changes. It failed one test : |
d61afab
to
a65da17
Compare
Fix the tests below and we can merge.
|
a65da17
to
4f92c3e
Compare
Your checklist for this pull request
Detailed description
Added
char * linkerversion
toRzBinInfo
struct andrz_bin_pe_get_linker
to get the linker version.Will be printed as
lnkrver 14.29
in the output. Did not uselinkerversion
because it changes the spacing and requires change in all testcases.Test plan
Changed the test
test/db/formats/pe/arm
to check forlnkrver
Closing issues
closes #4601