-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cutter-deps to QT6 #3363
Conversation
Tested it (basic testing procedure) on these platforms:
|
Both AppImages work for me (qt5 and qt6). Tested on Debian 11 x86_64
|
i have tested linux qt5 and qt6 and works.
|
This is probably obvious to everyone already but unless a special Qt5 build is added for Windows moving forwards this will mean support for Windows 7 will be dropped with this change. |
Sorry, pressed the wrong button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only revert the link to the Rizin repo please.
IMPORTANT
Do not merge before rizinorg/cutter-deps#16 is finished and switching cutter-deps-qt URL back to rizinorg !
IMPORTANT
This is part 3/3 from
Your checklist for this pull request
Detailed description
Update cutter deps to the new ones with QT6 and Python 3.12.
Reorganize Linux CI builds. There are now 4:
The new linux Appimage should now include Qt wayland backend.
macOS:
Do both x86_64 and ARM64 builds on GHA. This somewhat makes the woodpecker build redundant.
Do we still need it? If I remember correctly it was introduced when Github didn't have ARM64 builders yet. Currently not only github supports that but they are the default ones (macos-latest).
Meat of the testing should be done once the cutter-deps PR have been merged and this one is using using cutter-deps from them. I have done preliminary testing for most of the cases, but they should be redone with final build of cutter-deps once it's merged.
Followup tasks
Test plan (required)
In each platform config make sure:
Testing platforms:
Closing issues
closes #3211
unblocks #3296
TODO