Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append rizin results in plaintext to include tabs etc (fixes #3193) #3236

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

lionkor
Copy link
Contributor

@lionkor lionkor commented Aug 25, 2023

Your checklist for this pull request

Detailed description

See #3193

The output of rizin was formatted as html, which caused \n to become <br/>, making it impossible to just use appendPlainText() as-is. We have to tell rizin not to give us html, so that we can use \t in the output.

Simply replacing \t with spaces, &emsp; or similar doesn't work, as the appendHtml() replaces multiple spaces with one.

Test plan (required)

Enter the commands from the issue and others which may generate spaces.

Closing issues

closes #3193

…#3193)

the output of rizin was formatted as html, which caused \n to become
<br/>, making it impossible to just use appendPlainText() as-is. We have
to tell rizin not to give us html, so that we can use \t in the output.

Simply replacing \t with spaces, `&emsp;` or similar doesn't work, as
the appendHtml() replaces multiple spaces with one.
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. I don't recall why HTML was used.
@xarkes @thestr4ng3r any ideas?

@XVilka
Copy link
Member

XVilka commented Aug 27, 2023

By the way, we should support "true color" (16M colors), not 256 ones in Cutter too, as Rizin works perfectly with various other terminal emulators in this mode.

@xarkes
Copy link
Member

xarkes commented Aug 29, 2023

I think that in the past it was the easiest way to get formatted output from the core.

@XVilka XVilka merged commit 8f707e4 into rizinorg:dev Aug 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console does ignore tab characters at the beginning of a line
3 participants