Remove unnessary mouse grab.

* Causes warning spam with Qt wayland backend * Can sometimes cause crash on wayland * According to docs shouldn't be necesarry
rizinorg · Nov 11, 2023 · fe85af2 · fe85af2
1 parent 91f40f2
commit fe85af2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/src/widgets/ColorPicker.cpp b/src/widgets/ColorPicker.cpp
@@ -286,7 +286,6 @@ void ColorPicker::startPickingFromScreen()
 {
     if (!pickingFromScreen) {
         setMouseTracking(true);
-        grabMouse(Qt::CursorShape::CrossCursor);
         pickingFromScreen = true;
         bufferColor = currColor;
     }
@@ -298,7 +297,6 @@ void ColorPicker::mouseReleaseEvent(QMouseEvent *event)
         setColor(getColorAtMouse());
         pickingFromScreen = false;
         setMouseTracking(false);
-        releaseMouse();
     }
     QWidget::mouseReleaseEvent(event);
 }

diff --git a/src/widgets/GraphView.cpp b/src/widgets/GraphView.cpp
@@ -159,7 +159,6 @@ void GraphView::beginMouseDrag(QMouseEvent *event)
     scrollBase = event->pos();
     scroll_mode = true;
     setCursor(Qt::ClosedHandCursor);
-    viewport()->grabMouse();
 }
 
 void GraphView::setViewOffset(QPoint offset)
@@ -741,7 +740,6 @@ void GraphView::mouseReleaseEvent(QMouseEvent *event)
     if (scroll_mode && (event->buttons() & (Qt::LeftButton | Qt::MiddleButton)) == 0) {
         scroll_mode = false;
         setCursor(Qt::ArrowCursor);
-        viewport()->releaseMouse();
     }
 }