Remove JDK 14 and Add JDK 17 (opensearch-project#383)

Signed-off-by: Ashish Agrawal <[email protected]>

.github/workflows/bwc-test-workflow.yml

@@ -12,7 +12,7 @@ jobs:
   build:
     strategy:
       matrix:
-        java: [ 14 ]
+        java: [ 11 ]
     # Job name
     name: Build and test Alerting
     # This job runs on Linux
@@ -27,10 +27,10 @@ jobs:
       - name: Checkout Branch
         uses: actions/checkout@v2
       # This step uses the setup-java Github action: https://github.com/actions/setup-java
-      - name: Set Up JDK 14
+      - name: Set Up JDK 11
         uses: actions/setup-java@v1
         with:
-          java-version: 14
+          java-version: 11
       - name: Run Alerting Backwards Compatibility Tests
         run: |
           echo "Running backwards compatibility tests..."

.github/workflows/multi-node-test-workflow.yml

@@ -12,7 +12,7 @@ jobs:
   build:
     strategy:
       matrix:
-        java: [ 11 ]
+        java: [ 11, 17 ]
     # Job name
     name: Build and test Alerting
     # This job runs on Linux

.github/workflows/security-test-workflow.yml

@@ -12,7 +12,7 @@ jobs:
   build:
     strategy:
       matrix:
-        java: [ 11 ]
+        java: [ 11, 17 ]
     # Job name
     name: Build and test Alerting
     # This job runs on Linux
@@ -27,10 +27,10 @@ jobs:
       - name: Checkout Branch
         uses: actions/checkout@v2
       # This step uses the setup-java Github action: https://github.com/actions/setup-java
-      - name: Set Up JDK 11
+      - name: Set Up JDK ${{ matrix.java }}
         uses: actions/setup-java@v1
         with:
-          java-version: 11
+          java-version: ${{ matrix.java }}
       - name: Build Alerting
         # Only assembling since the full build is governed by other workflows
         run: ./gradlew assemble

.github/workflows/test-workflow.yml

@@ -12,7 +12,7 @@ jobs:
   build:
     strategy:
       matrix:
-        java: [11, 14]
+        java: [11, 17]
     # Job name
     name: Build Alerting with JDK ${{ matrix.java }}
     # This job runs on Linux

alerting/src/main/kotlin/org/opensearch/alerting/model/BucketLevelTriggerRunResult.kt

@@ -38,7 +38,7 @@ data class BucketLevelTriggerRunResult(
     override fun writeTo(out: StreamOutput) {
         super.writeTo(out)
         out.writeMap(aggregationResultBuckets, StreamOutput::writeString) {
-            valueOut: StreamOutput, aggResultBucket: AggregationResultBucket ->
+                valueOut: StreamOutput, aggResultBucket: AggregationResultBucket ->
             aggResultBucket.writeTo(valueOut)
         }
         out.writeMap(actionResultsMap as Map<String, Any>)

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestGetAlertsAction.kt

@@ -68,7 +68,7 @@ class RestGetAlertsAction : BaseRestHandler() {
 
         val getAlertsRequest = GetAlertsRequest(table, severityLevel, alertState, monitorId)
         return RestChannelConsumer {
-            channel ->
+                channel ->
             client.execute(GetAlertsAction.INSTANCE, getAlertsRequest, RestToXContentListener(channel))
         }
     }

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestGetDestinationsAction.kt

@@ -89,7 +89,7 @@ class RestGetDestinationsAction : BaseRestHandler() {
             destinationType
         )
         return RestChannelConsumer {
-            channel ->
+                channel ->
             client.execute(GetDestinationsAction.INSTANCE, getDestinationsRequest, RestToXContentListener(channel))
         }
     }

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestGetMonitorAction.kt

@@ -68,7 +68,7 @@ class RestGetMonitorAction : BaseRestHandler() {
         }
         val getMonitorRequest = GetMonitorRequest(monitorId, RestActions.parseVersion(request), request.method(), srcContext)
         return RestChannelConsumer {
-            channel ->
+                channel ->
             client.execute(GetMonitorAction.INSTANCE, getMonitorRequest, RestToXContentListener(channel))
         }
     }

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestIndexDestinationAction.kt

@@ -86,7 +86,7 @@ class RestIndexDestinationAction : BaseRestHandler() {
         }
         val indexDestinationRequest = IndexDestinationRequest(id, seqNo, primaryTerm, refreshPolicy, request.method(), destination)
         return RestChannelConsumer {
-            channel ->
+                channel ->
             client.execute(
                 IndexDestinationAction.INSTANCE, indexDestinationRequest,
                 indexDestinationResponse(channel, request.method())

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexDestinationAction.kt

@@ -306,7 +306,7 @@ class TransportIndexDestinationAction @Inject constructor(
             var failureReasons = StringBuilder()
             if (response.shardInfo.failed > 0) {
                 response.shardInfo.failures.forEach {
-                    entry ->
+                        entry ->
                     failureReasons.append(entry.reason())
                 }
                 return failureReasons.toString()

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailAccountAction.kt

@@ -300,7 +300,7 @@ class TransportIndexEmailAccountAction @Inject constructor(
             val failureReasons = StringBuilder()
             if (response.shardInfo.failed > 0) {
                 response.shardInfo.failures.forEach {
-                    entry ->
+                        entry ->
                     failureReasons.append(entry.reason())
                 }
 

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailGroupAction.kt

@@ -232,7 +232,7 @@ class TransportIndexEmailGroupAction @Inject constructor(
             val failureReasons = StringBuilder()
             if (response.shardInfo.failed > 0) {
                 response.shardInfo.failures.forEach {
-                    entry ->
+                        entry ->
                     failureReasons.append(entry.reason())
                 }
 

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt

@@ -477,7 +477,7 @@ class TransportIndexMonitorAction @Inject constructor(
             val failureReasons = StringBuilder()
             if (response.shardInfo.failed > 0) {
                 response.shardInfo.failures.forEach {
-                    entry ->
+                        entry ->
                     failureReasons.append(entry.reason())
                 }
                 return failureReasons.toString()

alerting/src/test/kotlin/org/opensearch/alerting/MonitorRunnerIT.kt

@@ -1007,7 +1007,7 @@ class MonitorRunnerIT : AlertingRestTestCase() {
             val output = entityAsMap(response)
             @Suppress("UNCHECKED_CAST")
             (output["trigger_results"] as HashMap<String, Any>).forEach {
-                _, v ->
+                    _, v ->
                 assertTrue((v as HashMap<String, Boolean>)["triggered"] as Boolean)
             }
             assertEquals(monitor.name, output["monitor_name"])
@@ -1037,7 +1037,7 @@ class MonitorRunnerIT : AlertingRestTestCase() {
             val output = entityAsMap(response)
             @Suppress("UNCHECKED_CAST")
             (output["trigger_results"] as HashMap<String, Any>).forEach {
-                _, v ->
+                    _, v ->
                 assertTrue((v as HashMap<String, Boolean>)["triggered"] as Boolean)
             }
             assertEquals(monitor.name, output["monitor_name"])
@@ -1064,7 +1064,7 @@ class MonitorRunnerIT : AlertingRestTestCase() {
             val output = entityAsMap(response)
             @Suppress("UNCHECKED_CAST")
             (output["trigger_results"] as HashMap<String, Any>).forEach {
-                _, v ->
+                    _, v ->
                 assertTrue((v as HashMap<String, Boolean>)["triggered"] as Boolean)
             }
             @Suppress("UNCHECKED_CAST")
@@ -1093,7 +1093,7 @@ class MonitorRunnerIT : AlertingRestTestCase() {
             val output = entityAsMap(response)
             @Suppress("UNCHECKED_CAST")
             (output["trigger_results"] as HashMap<String, Any>).forEach {
-                _, v ->
+                    _, v ->
                 assertFalse((v as HashMap<String, Boolean>)["triggered"] as Boolean)
             }
             @Suppress("UNCHECKED_CAST")

build.gradle

@@ -49,7 +49,7 @@ configurations {
 }
 
 dependencies {
-    add("ktlint", "com.pinterest:ktlint:0.41.0") {
+    add("ktlint", "com.pinterest:ktlint:0.45.1") {
         attributes {
             attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling, Bundling.EXTERNAL))
         }