Rithm add prop types #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misscoded
suggested changes
Jun 26, 2019
package.json
Outdated
| "pretty-quick": "^1.11.1", | ||
| "pretty-quick": "^1.8.0", | ||
| "prop-types": "^15.7.2", | ||
| "react-testing-library": "^5.4.2", |
src/components/ErrorToast.js
Outdated
| @@ -10,6 +11,10 @@ const ErrorToast = ({ message }) => { | |||
| ); | |||
| }; | |||
|
|
|||
| ErrorToast.propTypes = { | |||
There was a problem hiding this comment.
Be consistent -- propTypes before defaultProps or vice versa, not one or the other.
src/components/SidebarButton.test.js
Outdated
| @@ -6,7 +6,7 @@ afterEach(cleanup); | |||
|
|
|||
| describe('<SidebarButton/>', () => { | |||
| it('renders without crashing', () => { | |||
| global.renderWithRedux(<SidebarButton />); | |||
| global.renderWithRedux(<SidebarButton icon="icon" />); | |||
There was a problem hiding this comment.
removed, no longer needed with default props added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue [#41]
I added prop types and default props to the following components:
App.js
Burst.js
ErrorToast.js
Frame.js
Preview.js
Settings.js
Sidebar.js
SidebarButton.js
SidebarButtonWithBadge.js
Default props for connected components have been set to match initial state from the store, with there mapDispatchToProps functions have been set as simple arrow functions, i.e. () => {}. For non connected components, the default props have been set to match the properties applied where those components are rendered, i.e. where is rendered within
thanks!