Merge pull request #4 from japamat/rithm-burst-issue-16

Throws error on burst image capture when user inputs bad expression index

src/actions/action-creators.test.js

@@ -45,7 +45,10 @@ const desmosMock = {
   GraphingCalculator: jest.fn(() => {
     return {
       asyncScreenshot: (opts, cb) => cb(''),
-      getExpressions: () => [{ id: 1, latex: 'x = 3' }, { id: 2, latex: '' }],
+      getExpressions: () => [
+        { id: 1, type: 'expression', latex: 'x = 3' },
+        { id: 2, latex: '' }
+      ],
       setExpression: () => null
     };
   })

src/lib/calc-helpers.js

@@ -28,10 +28,14 @@ export const getImageData = opts =>
  */
 const getExpByIndex = idx => calculator.getExpressions()[idx - 1];
 
-// Returns an error message on failure.
+/**
+ * Returns an error message on failure.
+ * Skips expressions that are not of type 'expression'
+ */
 export const setSliderByIndex = (idx, val) => {
   const exp = getExpByIndex(idx);
   if (!exp) return noSuchExpression(idx);
+  if (exp.type !== 'expression') return notASlider(idx);
 
   const { id, latex } = exp;
   const match = latex.match(/(.+)=/);