clean up code for pull request

rithmschool · Jun 13, 2019 · 7ac5944 · 7ac5944
1 parent 6ca43c4
commit 7ac5944
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -10,14 +10,12 @@
     "react-redux": "^6.0.0",
     "react-scripts": "2.1.2",
     "redux": "^4.0.1",
-    "redux-devtools-extension": "^2.13.8",
     "redux-thunk": "^2.3.0"
   },
   "scripts": {
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test",
-    "test:debug": "react-scripts --inspect-brk test --runInBand --no-cache",
     "eject": "react-scripts eject",
     "predeploy": "npm run -s build",
     "deploy": "node scripts/deploy.js"

diff --git a/src/actions/action-creators.test.js b/src/actions/action-creators.test.js
@@ -6,7 +6,7 @@ import panes from '../constants/pane-types';
 import { initializeCalculator } from '../lib/calculator';
 
 const middlewares = [thunkMiddleware];
-let mockStore = configureMockStore(middlewares);
+const mockStore = configureMockStore(middlewares);
 
 describe('Action creators', () => {
   /***** sync *****/

diff --git a/src/actions/index.js b/src/actions/index.js
@@ -40,10 +40,6 @@ const ERROR_DELAY = 3000;
 let nextFrameID = 0;
 let errorTimeout;
 
-/********************************************************************************/
-/*** Synchronous ****************************************************************/
-/********************************************************************************/
-
 export const addFrame = imageData => ({
   type: types.ADD_FRAME,
   payload: {
@@ -170,7 +166,6 @@ export const requestBurst = opts => async (dispatch, getState) => {
   for (let val = min; val <= max; val += step) {
     sliderErrorMessage = setSliderByIndex(idx, val);
     if (sliderErrorMessage) {
-      dispatch(addFrame(sliderErrorMessage));
       dispatch(flashError(sliderErrorMessage));
       return;
     }

diff --git a/src/index.js b/src/index.js
@@ -1,7 +1,6 @@
 import React from 'react';
 import ReactDOM from 'react-dom';
 import { createStore, applyMiddleware } from 'redux';
-import { composeWithDevTools } from 'redux-devtools-extension';
 import { Provider } from 'react-redux';
 import thunkMiddleware from 'redux-thunk';
 import rootReducer from './reducers';
@@ -11,10 +10,7 @@ import { togglePane } from './actions';
 import greet from './lib/dev-greeting';
 import './index.css';
 
-const store = createStore(
-  rootReducer,
-  composeWithDevTools(applyMiddleware(thunkMiddleware))
-);
+const store = createStore(rootReducer, applyMiddleware(thunkMiddleware));
 
 const closePane = () => store.dispatch(togglePane(panes.NONE));