Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pregenerate and use a person display_name to disambiguate similar ones #1609

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fjorba
Copy link
Contributor

@fjorba fjorba commented Jul 9, 2024

When different people share the same or similar name, other fields are used to distinguish them, like life dates. In Muscat, this richer form of name is used, at least, in autocomplete forms, although it could be used on other places. Instead of building it each time, create it once and store it in db.

When different people share the same or similar name, other fields are used
to distinguish them, like life dates.  In Muscat, this richer form of name
is used, at least, in autocomplete forms, although it could be used on other
places.  Instead of building it each time, create it once and store it in db.
@fjorba
Copy link
Contributor Author

fjorba commented Jul 9, 2024

This patch does not address the scenario of empty display_name fields when they are not yet created. In my instances, they are already pregenerated during the import phase. Maybe a temporary solution could be to check in autocomplete_label if its empty and, in that case, call set_object_fields and save before doing a retrospective creation with a specific job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant